Skip to content

fix(quake): reject nodes without subnets - #386

Closed
kriss39 wants to merge 2 commits into
circlefin:mainfrom
kriss39:fix/quake-empty-subnets
Closed

kriss39 wants to merge 2 commits into
circlefin:mainfrom
kriss39:fix/quake-empty-subnets

Conversation

@kriss39

@kriss39 kriss39 commented Sep 12, 2026

Copy link
Copy Markdown

Summary

Reject Quake manifests where a node is configured with an empty subnet list.

This catches the invalid configuration during manifest validation instead of failing later during network setup.

Tests

Added a regression test for subnets = [].

@ZhiyuCircle

Copy link
Copy Markdown
Contributor

Hi @kriss39,

Thank you for your interest in contributing to Arc Node, and apologies for the delay in getting back to this PR.

We're closing out the pull request backlog that predates our current contribution policy. This PR is being closed because it does not reference a GitHub issue. All PRs must reference an existing issue using the format Closes: #XXX, and the author must be assigned to that issue before the PR is opened.

This is not a judgement on the change itself. If you'd still like to land it:

  1. Open an issue describing the problem, or find the existing one
  2. Comment on the issue requesting assignment, and wait for maintainer approval
  3. Open a fresh PR once you have been assigned

Please see CONTRIBUTING.md for details. Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants