Conversation
…lot layout pack_gas_values_for_storage writes nextBaseFee to bytes [8..16], but the layout comment lists only gasUsedSmoothed and gasUsed. The comment predates the nextBaseFee field. Add the missing line.
Ruzzgar
requested review from
ZhiyuCircle,
ancazamfir,
romac and
sergio-mena
as code owners
September 13, 2026 01:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pack_gas_values_for_storagepacks three fields into the slot:but the layout comment above it lists only the first two. The comment predates the
nextBaseFeefield (the Zero3 test helper, which really does pack two fields, carries the same text). Add the missing line.Comment only —
unpack_gas_values_from_storagealready reads[8..16]and the existing round-trip test coversnextBaseFee.