decoder: guard threaded DPB reallocation - #3972
Open
BenzhengZhang wants to merge 4 commits into
Open
Conversation
added 4 commits
July 29, 2026 10:41
Merge the two consecutive bNewSeqBegin blocks and drop the redundant pLastThreadCtx reset in ThreadDecodeFrameInternal; the barrier path already clears it before the DPB is reused. No behavior change.
…counting In threaded decoding the shared DPB may be reallocated by any worker thread's context on a new sequence, but is freed via the primary context at teardown, leaving per-context MEMORY_MONITOR accounting imbalanced (asserts in debug/meson builds; no real leak). Record the allocating CMemoryAlign in SPicBuff and free through it.
Alternating IDR frames at two resolutions through the multi-threaded decoder reproduce the DPB reallocation use-after-free (SPARK-801586) before the guard fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.