Skip to content

Update dynamic_array container again #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ckormanyos merged 1 commit into from
Jun 8, 2026
Merged

Update dynamic_array container again #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/wide_integer_sonar.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
uses: SonarSource/sonarqube-scan-action/install-build-wrapper@v6.0.0
- name: Run Build Wrapper
run: |
build-wrapper-linux-x86-64 --out-dir ${{ runner.workspace }}/build_wrapper_output_directory g++ -finline-functions -m64 -O3 -Werror -Wall -Wextra -Wconversion -Wsign-conversion -std=c++14 -DWIDE_INTEGER_HAS_LIMB_TYPE_UINT64 -DWIDE_INTEGER_HAS_MUL_8_BY_8_UNROLL -I. -I../boost-root -pthread -lpthread test/test.cpp test/test_uintwide_t_boost_backend.cpp test/test_uintwide_t_edge_cases.cpp test/test_uintwide_t_examples.cpp test/test_uintwide_t_float_convert.cpp test/test_uintwide_t_int_convert.cpp test/test_uintwide_t_n_base.cpp test/test_uintwide_t_n_binary_ops_base.cpp test/test_uintwide_t_spot_values.cpp examples/example000_numeric_limits.cpp examples/example000a_builtin_convert.cpp examples/example001_mul_div.cpp examples/example001a_div_mod.cpp examples/example002_shl_shr.cpp examples/example003_sqrt.cpp examples/example003a_cbrt.cpp examples/example004_rootk_pow.cpp examples/example005_powm.cpp examples/example005a_pow_factors_of_p99.cpp examples/example006_gcd.cpp examples/example007_random_generator.cpp examples/example008_miller_rabin_prime.cpp examples/example008a_miller_rabin_prime.cpp examples/example008b_solovay_strassen_prime.cpp examples/example009_timed_mul.cpp examples/example009a_timed_mul_4_by_4.cpp examples/example009b_timed_mul_8_by_8.cpp examples/example010_uint48_t.cpp examples/example011_uint24_t.cpp examples/example012_rsa_crypto.cpp examples/example013_ecdsa_sign_verify.cpp examples/example014_pi_spigot_wide.cpp -o wide_integer.exe
build-wrapper-linux-x86-64 --out-dir ${{ runner.workspace }}/build_wrapper_output_directory g++ -finline-functions -m64 -O3 -Werror -Wall -Wextra -Wpedantic -Wconversion -Wsign-conversion -std=c++14 -DWIDE_INTEGER_HAS_LIMB_TYPE_UINT64 -DWIDE_INTEGER_HAS_MUL_8_BY_8_UNROLL -I. -I../boost-root -pthread -lpthread test/test.cpp test/test_uintwide_t_boost_backend.cpp test/test_uintwide_t_edge_cases.cpp test/test_uintwide_t_examples.cpp test/test_uintwide_t_float_convert.cpp test/test_uintwide_t_int_convert.cpp test/test_uintwide_t_n_base.cpp test/test_uintwide_t_n_binary_ops_base.cpp test/test_uintwide_t_spot_values.cpp examples/example000_numeric_limits.cpp examples/example000a_builtin_convert.cpp examples/example001_mul_div.cpp examples/example001a_div_mod.cpp examples/example002_shl_shr.cpp examples/example003_sqrt.cpp examples/example003a_cbrt.cpp examples/example004_rootk_pow.cpp examples/example005_powm.cpp examples/example005a_pow_factors_of_p99.cpp examples/example006_gcd.cpp examples/example007_random_generator.cpp examples/example008_miller_rabin_prime.cpp examples/example008a_miller_rabin_prime.cpp examples/example008b_solovay_strassen_prime.cpp examples/example009_timed_mul.cpp examples/example009a_timed_mul_4_by_4.cpp examples/example009b_timed_mul_8_by_8.cpp examples/example010_uint48_t.cpp examples/example011_uint24_t.cpp examples/example012_rsa_crypto.cpp examples/example013_ecdsa_sign_verify.cpp examples/example014_pi_spigot_wide.cpp -o wide_integer.exe
- name: SonarQube Scan
uses: SonarSource/sonarqube-scan-action@v6.0.0
env:
Expand Down
113 changes: 60 additions & 53 deletions math/wide_integer/uintwide_t.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,7 +718,9 @@

while(it != end())
{
*it++ = value_in;
std::allocator_traits<allocator_type>::construct(my_alloc, it, value_in);

++it;
}
}
}
Expand All @@ -739,9 +741,9 @@
}
}

template<typename input_iterator>
constexpr dynamic_array(input_iterator first,
input_iterator last,
template<typename InputIterator>
constexpr dynamic_array(InputIterator first,
InputIterator last,
const allocator_type& alloc_in = allocator_type())
: elem_count(static_cast<size_type>(last - first)),
my_alloc(alloc_in)
Expand Down Expand Up @@ -784,6 +786,28 @@
other.elems = nullptr;
}

// Destructor.
virtual ~dynamic_array()
{
if(!empty())
{
// The destructors of the elements are called (in unspecified order)
// and the dynamically allocated storage (if any) is deallocated.

for(auto* itr { begin() }; itr != end(); ++itr) // NOLINT(cppcoreguidelines-pro-bounds-pointer-arithmetic)
{
itr->~value_type();
}

using local_allocator_traits_type = std::allocator_traits<allocator_type>;

local_allocator_traits_type::deallocate(my_alloc, elems, elem_count);

elem_count = static_cast<size_type>(UINT8_C(0));
elems = nullptr;
}
}

// Assignment operator.
constexpr auto operator=(const dynamic_array& other) -> dynamic_array&
{
Expand All @@ -801,9 +825,9 @@
#else
other.elems + ::math::wide_integer::detail::min_unsafe
#endif
(
elem_count, other.elem_count
),
(
elem_count, other.elem_count
),
elems
);
}
Expand Down Expand Up @@ -834,63 +858,41 @@
return *this;
}

// Destructor.
virtual ~dynamic_array()
{
if(!empty())
{
// The destructors of the elements are called (in unspecified order)
// and the dynamically allocated storage (if any) is deallocated.

for(auto* itr { begin() }; itr != end(); ++itr) // NOLINT(cppcoreguidelines-pro-bounds-pointer-arithmetic)
{
itr->~value_type();
}

using local_allocator_traits_type = std::allocator_traits<allocator_type>;

local_allocator_traits_type::deallocate(my_alloc, elems, elem_count);

elem_count = static_cast<size_type>(UINT8_C(0));
elems = nullptr;
}
}

// Iterator members:
WIDE_INTEGER_NODISCARD constexpr auto begin () -> iterator { return elems; }
WIDE_INTEGER_NODISCARD constexpr auto end () -> iterator { return elems + elem_count; }
WIDE_INTEGER_NODISCARD constexpr auto begin () const -> const_iterator { return elems; }
WIDE_INTEGER_NODISCARD constexpr auto end () const -> const_iterator { return elems + elem_count; }
WIDE_INTEGER_NODISCARD constexpr auto cbegin () const -> const_iterator { return elems; }
WIDE_INTEGER_NODISCARD constexpr auto cend () const -> const_iterator { return elems + elem_count; }
WIDE_INTEGER_NODISCARD constexpr auto rbegin () -> reverse_iterator { return reverse_iterator(elems + elem_count); }
WIDE_INTEGER_NODISCARD constexpr auto rend () -> reverse_iterator { return reverse_iterator(elems); }
WIDE_INTEGER_NODISCARD constexpr auto rbegin () const -> const_reverse_iterator { return const_reverse_iterator(elems + elem_count); }
WIDE_INTEGER_NODISCARD constexpr auto rend () const -> const_reverse_iterator { return const_reverse_iterator(elems); }
WIDE_INTEGER_NODISCARD constexpr auto crbegin() const -> const_reverse_iterator { return const_reverse_iterator(elems + elem_count); }
WIDE_INTEGER_NODISCARD constexpr auto crend () const -> const_reverse_iterator { return const_reverse_iterator(elems); }
WIDE_INTEGER_NODISCARD constexpr auto begin () noexcept -> iterator { return elems; }
WIDE_INTEGER_NODISCARD constexpr auto end () noexcept -> iterator { return elems + elem_count; }
WIDE_INTEGER_NODISCARD constexpr auto begin () const noexcept -> const_iterator { return elems; }
WIDE_INTEGER_NODISCARD constexpr auto end () const noexcept -> const_iterator { return elems + elem_count; }
WIDE_INTEGER_NODISCARD constexpr auto cbegin () const noexcept -> const_iterator { return elems; }
WIDE_INTEGER_NODISCARD constexpr auto cend () const noexcept -> const_iterator { return elems + elem_count; }
WIDE_INTEGER_NODISCARD constexpr auto rbegin () noexcept -> reverse_iterator { return reverse_iterator(elems + elem_count); }
WIDE_INTEGER_NODISCARD constexpr auto rend () noexcept -> reverse_iterator { return reverse_iterator(elems); }
WIDE_INTEGER_NODISCARD constexpr auto rbegin () const noexcept -> const_reverse_iterator { return const_reverse_iterator(elems + elem_count); }
WIDE_INTEGER_NODISCARD constexpr auto rend () const noexcept -> const_reverse_iterator { return const_reverse_iterator(elems); }
WIDE_INTEGER_NODISCARD constexpr auto crbegin() const noexcept -> const_reverse_iterator { return const_reverse_iterator(elems + elem_count); }
WIDE_INTEGER_NODISCARD constexpr auto crend () const noexcept -> const_reverse_iterator { return const_reverse_iterator(elems); }

// Raw pointer access.
WIDE_INTEGER_NODISCARD constexpr auto data() -> pointer { return elems; }
WIDE_INTEGER_NODISCARD constexpr auto data() const -> const_pointer { return elems; }
WIDE_INTEGER_NODISCARD constexpr auto data() noexcept -> pointer { return elems; }
WIDE_INTEGER_NODISCARD constexpr auto data() const noexcept -> const_pointer { return elems; }

// Size and capacity.
WIDE_INTEGER_NODISCARD constexpr auto size () const noexcept -> size_type { return elem_count; }
WIDE_INTEGER_NODISCARD constexpr auto max_size() const noexcept -> size_type { return elem_count; }
WIDE_INTEGER_NODISCARD constexpr auto empty () const noexcept -> bool { return (elem_count == static_cast<size_type>(UINT8_C(0))); }

// Element access members.
WIDE_INTEGER_NODISCARD constexpr auto operator[](const size_type i) -> reference { return elems[i]; }
WIDE_INTEGER_NODISCARD constexpr auto operator[](const size_type i) const -> const_reference { return elems[i]; }
WIDE_INTEGER_NODISCARD constexpr auto operator[](const size_type i) noexcept -> reference { return elems[i]; }
WIDE_INTEGER_NODISCARD constexpr auto operator[](const size_type i) const noexcept -> const_reference { return elems[i]; }

WIDE_INTEGER_NODISCARD constexpr auto front() -> reference { return elems[static_cast<size_type>(UINT8_C(0))]; }
WIDE_INTEGER_NODISCARD constexpr auto front() const -> const_reference { return elems[static_cast<size_type>(UINT8_C(0))]; }
WIDE_INTEGER_NODISCARD constexpr auto front() noexcept -> reference { return elems[static_cast<size_type>(UINT8_C(0))]; }
WIDE_INTEGER_NODISCARD constexpr auto front() const noexcept -> const_reference { return elems[static_cast<size_type>(UINT8_C(0))]; }

WIDE_INTEGER_NODISCARD constexpr auto back() -> reference { return ((elem_count > static_cast<size_type>(UINT8_C(0))) ? elems[static_cast<size_type>(elem_count - static_cast<size_type>(UINT8_C(1)))] : elems[static_cast<size_type>(UINT8_C(0))]); }
WIDE_INTEGER_NODISCARD constexpr auto back() const -> const_reference { return ((elem_count > static_cast<size_type>(UINT8_C(0))) ? elems[static_cast<size_type>(elem_count - static_cast<size_type>(UINT8_C(1)))] : elems[static_cast<size_type>(UINT8_C(0))]); }
WIDE_INTEGER_NODISCARD constexpr auto back() noexcept -> reference { return ((elem_count > static_cast<size_type>(UINT8_C(0))) ? elems[static_cast<size_type>(elem_count - static_cast<size_type>(UINT8_C(1)))] : elems[static_cast<size_type>(UINT8_C(0))]); }
WIDE_INTEGER_NODISCARD constexpr auto back() const noexcept -> const_reference { return ((elem_count > static_cast<size_type>(UINT8_C(0))) ? elems[static_cast<size_type>(elem_count - static_cast<size_type>(UINT8_C(1)))] : elems[static_cast<size_type>(UINT8_C(0))]); }

WIDE_INTEGER_NODISCARD constexpr auto at(const size_type i) -> reference { return ((i < elem_count) ? elems[i] : elems[static_cast<size_type>(UINT8_C(0))]); }
WIDE_INTEGER_NODISCARD constexpr auto at(const size_type i) const -> const_reference { return ((i < elem_count) ? elems[i] : elems[static_cast<size_type>(UINT8_C(0))]); }
WIDE_INTEGER_NODISCARD constexpr auto at(const size_type i) noexcept -> reference { return ((i < elem_count) ? elems[i] : elems[static_cast<size_type>(UINT8_C(0))]); }
WIDE_INTEGER_NODISCARD constexpr auto at(const size_type i) const noexcept -> const_reference { return ((i < elem_count) ? elems[i] : elems[static_cast<size_type>(UINT8_C(0))]); }

// Element manipulation members.
constexpr auto fill(const value_type& value_in) -> void
Expand Down Expand Up @@ -1595,7 +1597,7 @@
template<typename ValueType,
const size_t MySize,
typename AllocatorType>
class fixed_dynamic_array final : public detail::dynamic_array<ValueType, AllocatorType, size_t, ptrdiff_t> // NOLINT(cppcoreguidelines-special-member-functions,hicpp-special-member-functions)

Check failure on line 1600 in math/wide_integer/uintwide_t.h

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Customize this class' destructor to participate in resource management. 


See more on https://sonarcloud.io/project/issues?id=ckormanyos_wide-integer&issues=AZ6mOdwC_RvxFH7RvAk4&open=AZ6mOdwC_RvxFH7RvAk4&pullRequest=511
{
private:
using base_class_type = detail::dynamic_array<ValueType, AllocatorType, size_t, ptrdiff_t>;
Expand All @@ -1622,7 +1624,7 @@
const allocator_type& alloc_in = allocator_type())
: base_class_type(static_size(), value_in, alloc_in)
{
// This parameter is specifically ignored.
// This parameter is explicitly and purposely ignored.
static_cast<void>(size_in);
}

Expand All @@ -1649,7 +1651,12 @@

constexpr auto operator=(const fixed_dynamic_array&) -> fixed_dynamic_array& = default;

constexpr auto operator=(fixed_dynamic_array&&) noexcept -> fixed_dynamic_array& = default;
constexpr auto operator=(fixed_dynamic_array&& other) noexcept -> fixed_dynamic_array&
{
base_class_type::operator=(static_cast<base_class_type&&>(other));

return *this;
}
};

template<typename T>
Expand Down
Loading