Repository navigation
feat(mosaic): follow DirectionProvider for arrow-key navigation - #10420
Draft
alexcarpenter wants to merge 1 commit into
Draft
alexcarpenter wants to merge 1 commit into
alexcarpenter wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: f5f5dde The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-native-components
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mosaic primitives now take the reading direction for keyboard navigation from React context, as Base UI does, instead of reading the nearest
[dir]attribute.DirectionProvideranduseDirection()inprimitives/direction-provider.directionis'ltr' | 'rtl'and defaults to'ltr'.useDirection()returns'ltr'when no provider is mounted.MosaicProvidergets adirectionprop and rendersDirectionProviderfrom it. The prop is explicit rather than derived fromlocalization.locale. Layout follows the page'sdir, so keyboard direction should follow the value the host sets there, not the locale.useDirection(). Tabs and segmented control used to readdironly on focus, so they now pick up a direction change while focused.readingDirectionKeys(direction)moves from tag input into the provider module so OTP can use it too.rtltouseListNavigation, so in RTL ArrowLeft opens a submenu and ArrowRight closes it. Before this, they always used LTR keys.primitives/utils/dom.tsstill reads computeddirectionfor wheel/scroll delta math, which isn't keyboard direction (Base UI also keeps computed style for scrollbar hit testing).StoryMosaicProviderpasses the RTL toggle's value toMosaicProvider. This is typechecked but hasn't been exercised in the browser.This replaces #10419. The Table primitive (#10414) will switch to
useDirection()once both land.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change