[VRF-286] Adiciona encrypted-media no script de embedded do Verify#169
Open
franciscoemanuel-clk wants to merge 1 commit into
Open
[VRF-286] Adiciona encrypted-media no script de embedded do Verify#169franciscoemanuel-clk wants to merge 1 commit into
franciscoemanuel-clk wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Atualiza o SDK de embedded do Verify para permitir encrypted-media no atributo allow do iframe, viabilizando recursos que dependem dessa permissão sem alterar o comportamento padrão dos outros embeds.
Changes:
- Adiciona
encrypted-mediaà lista de permissões doallowno embed do Verify. - Refatora o
BaseEmbedpara usar um getter (allowed) e permitir override por subclasses. - Atualiza/adiciona testes garantindo o
allowesperado para Verify e mantendo o default no Signature.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/v3/src/verify/embedded.js | Override de permissões do iframe (allow) para incluir encrypted-media. |
| packages/v3/src/core/base-embed.js | Introduz getter allowed e passa a usá-lo ao montar o iframe. |
| packages/v3/src/verify/embedded.spec.js | Ajusta o teste para validar encrypted-media no allow do Verify. |
| packages/v3/src/signature/embedded.spec.js | Adiciona teste para garantir que o Signature mantém as permissões default. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| get allowed() { | ||
| return 'camera;geolocation;fullscreen;gyroscope;accelerometer;magnetometer;encrypted-media'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descrição
Adiciona encrypted-media à lista de permissões do allow do iframe gerado pelo SDK do Verify.
Issue tracker
[Link para o card no Jira.]
Code Review
Como fazer o Code Review:
CONTRIBUTING.md
Screenshots (para mudanças de UI, se houver)
[Adicione alguns screenshots das mudanças de UI inclusas no seu PR, se houver. Isso ajuda o revisor a entender como o usuário utilizaria o código do PR.]
Links e observações
[Links úteis que podem contextualizar e ajudar o revisor, por exemplo para a página de uma dependência que escolheu adicionar, ou um código que se inspirou, ou documentação externa (docs de uma API, do Vue, do Rails, etc).]
Checklist para poder mergear