Skip to content

fix(joint-react): deliver useOnElementsMeasured once per settled change #3518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumilingus merged 5 commits into from
Oct 1, 2026
Merged

fix(joint-react): deliver useOnElementsMeasured once per settled change #3518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3694337
fix(joint-react): ensure useOnElementsMeasured fires only for measure…
samuelgja Sep 24, 2026
641a361
feat: enhance measurement handling in graph store and related hooks
samuelgja Sep 29, 2026
e902506
fix(joint-react): update renderElement to accept a label prop for bet…
samuelgja Sep 30, 2026
d4f6835
refactor: enhance useOnElementsMeasured to handle zero-sized and cull…
samuelgja Oct 1, 2026
5ea9221
fix(joint-react): ensure useOnElementsMeasured fires once per settled…
samuelgja Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/react-elements-measured-app-resize.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@joint/react": patch
---

useOnElementsMeasured - fix to fire exactly once per settled change, when no element is still waiting to be measured
5 changes: 5 additions & 0 deletions packages/joint-react/src/components/paper/render-element/paper-element-item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ function SVGElementItemComponent(props: ElementItemProps) {
const graphStore = useGraphStore();
const { paper } = usePaper();
useLayoutEffect(() => {
// Runs after the portal subtree's layout effects, so a `useMeasureElement`
// inside `renderElement` has already registered with the size observer
// (in HTML overlay mode this item follows `HTMLElementItem`, which renders
// the user content, in sibling order). O(1), and a no-op on re-runs.
graphStore.markElementRendered(id);
if (!paper) return;
graphStore.clearViewForElementAndLinks({
cellId: id,
Expand Down
Loading
Loading