Initialize Percentage field in TaskGroup structs#67
Open
clobrano wants to merge 1 commit into
Open
Conversation
Set Percentage to -1 (not applicable) in GroupByTag() and GroupByProject() so renderGroupLine() skips the percentage display. The default zero value was being rendered as [ 0%]. Fixes #10 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lg8t7KbbcrNAiYcbLT4JZE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the
GroupByProjectandGroupByTagfunctions to initialize thePercentagefield when creatingTaskGroupstructs. This ensures the field is explicitly set rather than relying on zero-value initialization.Changes
Percentage: -1initialization inGroupByProjectfunction when creating TaskGroup instancesPercentage: -1initialization inGroupByTagfunction when creating TaskGroup instancesImplementation Details
The
Percentagefield is initialized to-1in both grouping functions, which likely serves as a sentinel value indicating that the percentage has not yet been calculated. This explicit initialization makes the intent clearer and ensures consistent behavior across all TaskGroup creation paths.https://claude.ai/code/session_01Lg8t7KbbcrNAiYcbLT4JZE