Skip to content

Pipeline wasm module operations#4973

Open
joshua-spacetime wants to merge 8 commits intomasterfrom
joshua/pipelined-wasm
Open

Pipeline wasm module operations#4973
joshua-spacetime wants to merge 8 commits intomasterfrom
joshua/pipelined-wasm

Conversation

@joshua-spacetime
Copy link
Copy Markdown
Collaborator

Description of Changes

The equivalent changes as #4962 but for wasm.

API and ABI breaking changes

See #4962

Expected complexity level and risk

4

Testing

See #4962

Copy link
Copy Markdown
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I'll leave it to Noa to also review and approve.

Copy link
Copy Markdown
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick q on this

Comment thread crates/cli/src/subcommands/subscribe.rs
Copy link
Copy Markdown
Collaborator

@coolreader18 coolreader18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread crates/core/src/host/module_host.rs Outdated
Comment thread crates/core/src/host/module_host.rs Outdated
Copy link
Copy Markdown
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cli changes look fine to me, not tested by me

@joshua-spacetime joshua-spacetime force-pushed the joshua/pipelined-wasm branch from 747b226 to dc989eb Compare May 7, 2026 17:59
@joshua-spacetime joshua-spacetime added the api-break A PR that makes an API breaking change label May 7, 2026
@joshua-spacetime joshua-spacetime enabled auto-merge May 7, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-break A PR that makes an API breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants