TypeScript HTTP handlers - Module Bindings#4980
Open
JasonAtClockwork wants to merge 5 commits intophoebe/http-handler/v8-hostfrom
Open
TypeScript HTTP handlers - Module Bindings#4980JasonAtClockwork wants to merge 5 commits intophoebe/http-handler/v8-hostfrom
JasonAtClockwork wants to merge 5 commits intophoebe/http-handler/v8-hostfrom
Conversation
…http_shared to avoid circular references
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Cleaning up the TypeScript HTTP handler module bindings on top of the V8 host/module work from #4931.
API and ABI breaking changes
Cleaning up the API layer:
Expected complexity level and risk
2 - I needed to move code out of http_internal.ts to have it shareable for http_handler.ts adding more churn than I'd like.
Testing