build: pin ethnum to 1.5.3 - #5712
Conversation
|
|
|
Thanks for the PR. Have you confirmed that this resolves the issue that would previously break downstream users? |
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
|
I was unable to repro the original issue without this PR (presumably because cargo chose the latest compatible version anyway) but still reasonable to bump the version. Added a comment and remove the |
|
I haven't heard back from @0xkaushik-ai and the CLA is unsigned, so I'm going to close this PR. Feel free to reopen if you'd like to sign the CLA and get this merged! |
Description of Changes
Pins the workspace
ethnumdependency to exactly 1.5.3. Versions before 1.5.3 rely on the representation of an error type that changed in newer Rust toolchains, which can break downstream users even though SpacetimeDB's pinned toolchain is unaffected.The lockfile already resolved
ethnum1.5.3, so no lockfile update is required.Fixes #5512.
API and ABI breaking changes
None.
Expected complexity level and risk
Cargo.lock.Testing
cargo metadata --locked --no-deps --format-version 1cargo check --locked -p spacetimedb-sats -p spacetimedb-expr -p spacetimedb-table -p spacetimedb-memory-usagecargo test --locked -p spacetimedb-sats -p spacetimedb-expr -p spacetimedb-table -p spacetimedb-memory-usage --libgit diff --check