Skip to content

build: pin ethnum to 1.5.3 - #5712

Closed
0xkaushik-ai wants to merge 3 commits into
clockworklabs:masterfrom
0xkaushik-ai:fix/pin-ethnum-1.5.3
Closed

build: pin ethnum to 1.5.3#5712
0xkaushik-ai wants to merge 3 commits into
clockworklabs:masterfrom
0xkaushik-ai:fix/pin-ethnum-1.5.3

Conversation

@0xkaushik-ai

Copy link
Copy Markdown

Description of Changes

Pins the workspace ethnum dependency to exactly 1.5.3. Versions before 1.5.3 rely on the representation of an error type that changed in newer Rust toolchains, which can break downstream users even though SpacetimeDB's pinned toolchain is unaffected.

The lockfile already resolved ethnum 1.5.3, so no lockfile update is required.

Fixes #5512.

API and ABI breaking changes

None.

Expected complexity level and risk

  1. This is a one-line workspace dependency constraint change to the version already present in Cargo.lock.

Testing

  • cargo metadata --locked --no-deps --format-version 1
  • cargo check --locked -p spacetimedb-sats -p spacetimedb-expr -p spacetimedb-table -p spacetimedb-memory-usage
  • cargo test --locked -p spacetimedb-sats -p spacetimedb-expr -p spacetimedb-table -p spacetimedb-memory-usage --lib
  • git diff --check

@CLAassistant

CLAassistant commented Aug 10, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ bfops
❌ 0xkaushik-ai
You have signed the CLA already but the status is still pending? Let us recheck it.

@bfops

bfops commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the PR. Have you confirmed that this resolves the issue that would previously break downstream users?

Comment thread Cargo.toml Outdated
bfops added 2 commits August 24, 2026 09:34
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
@bfops

bfops commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

I was unable to repro the original issue without this PR (presumably because cargo chose the latest compatible version anyway) but still reasonable to bump the version. Added a comment and remove the = constraint since default constraint is good enough.

@bfops

bfops commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

I haven't heard back from @0xkaushik-ai and the CLA is unsigned, so I'm going to close this PR. Feel free to reopen if you'd like to sign the CLA and get this merged!

@bfops bfops closed this Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update and pin ethnum to 1.5.3

3 participants