Skip to content

Remove redundant builds from unity, godot, csharp, and typescript test suites - #5797

Open
joshua-spacetime wants to merge 5 commits into
masterfrom
joshua/ci/remove-more-deps
Open

Remove redundant builds from unity, godot, csharp, and typescript test suites#5797
joshua-spacetime wants to merge 5 commits into
masterfrom
joshua/ci/remove-more-deps

Conversation

@joshua-spacetime

@joshua-spacetime joshua-spacetime commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Description of Changes

Removes redundant CLI and standalone builds from four CI jobs:

  1. test
    • Previously cargo ci test built release CLI and standalone.
    • Now uses cargo ci test --prebuilt-runtime.
  2. unity-testsuite
    • Previously ran cargo install for CLI and standalone.
    • Now downloads both from build-artifacts-linux.
  3. godot-testsuite
    • Previously ran cargo install for CLI and standalone.
    • Now downloads both from build-artifacts-linux.
  4. csharp-testsuite
    • Previously ran cargo install for CLI and standalone, while its helper scripts also used Cargo.
    • Now downloads both and supplies the CLI through SPACETIME_BIN.
  5. typescript-test
    • Previously built CLI and standalone through Cargo.
    • Now downloads both from build-artifacts-linux and uses cargo ci typescript-test --prebuilt-runtime.
    • Added cargo ci run-spacetime which selects the prebuilt runtime in CI while preserving source builds locally.
  6. Gut and rename cargo ci wasm-bindings since most of it is already covered in the test suite.

API and ABI breaking changes

None

Expected complexity level and risk

2

Testing

The unity, godot, csharp and typescript test suites should be substantially faster which should reduce runner congestion.

Download shared artifacts instead.
@joshua-spacetime
joshua-spacetime force-pushed the joshua/ci/remove-more-deps branch 2 times, most recently from 6a98120 to 959adb7 Compare August 25, 2026 18:43
@joshua-spacetime
joshua-spacetime force-pushed the joshua/ci/remove-more-deps branch from 959adb7 to 1e3ab0b Compare August 25, 2026 19:02
@joshua-spacetime joshua-spacetime changed the title Remove redundant cli and standalone builds from unity, godot, and csharp test suites Remove redundant builds from unity, godot, csharp, and typescript test suites Aug 25, 2026
"publish": "cargo run -p spacetimedb-cli -- publish"
"build": "cargo ci run-spacetime build",
"generate-ts": "cargo ci run-spacetime generate --lang typescript --out-dir ts-codegen",
"publish": "cargo ci run-spacetime publish"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally a bit wary of these repo-specific scripts embedded in our templates shipped to users, but this is no more repo-dependent than before

@bfops bfops left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty great, a couple of comments

Comment thread Cargo.toml
Comment thread tools/ci/src/main.rs Outdated
Comment thread tools/ci/commands/test/src/main.rs Outdated
Comment thread tools/ci/commands/typescript-test/src/main.rs Outdated
@joshua-spacetime
joshua-spacetime requested a review from bfops August 26, 2026 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants