Fix two broken fragment links and label master in the docs version menu - #4194
Merged
Merged
Conversation
The site builds section ids with no prefix and dashes as separators, so `#_selecting_the_form_to_operate_on` never resolved; the inspector and macroexpansion pages linked to it and landed at the top of the page.
Unversioned components show up as "default" in the menu, which tells the reader nothing. Call it master, and spell out in the descriptor that the release commit has to quote the version: 2.0 unquoted is the number 2 to YAML, which is how the 2.0 docs came to be listed as "2".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two pages linked to
#_selecting_the_form_to_operate_on, but the site generates ids without the underscore prefix, so the links landed at the top of the page. The version menu also called the master docs "default"; they're now labelled master, and the descriptor notes that the release commit must quote the version, since an unquoted 2.0 is what got the 2.0 docs listed as "2". Verified with a local site build.