Take the setup snippets' versions from antora.yml attributes - #4195
Merged
Merged
Conversation
Every manual snippet that pins cider-nrepl said 0.59.0 while CIDER has been injecting 0.62.2, the piggieback pins were two releases behind, and the troubleshooting page still asked for Clojure 1.7 when CIDER requires 1.10. Define the versions once as component attributes and reference them from the snippets, so a release bumps one file instead of hunting through nine pages. The indented literal paragraph in up_and_running and the Markdown-style fence in the shadow-cljs page become proper source blocks, since attribute substitution needs subs="attributes+" on the block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manual pinned cider-nrepl 0.59.0 in nine snippets while CIDER injects 0.62.2, piggieback was two releases behind, and troubleshooting still asked for Clojure 1.7. The versions are now component attributes in doc/antora.yml with a comment on where they come from, and the snippets reference them. Verified with a local site build that every reference is substituted.