Repository navigation
Show test progress while the tests run - #4206
Merged
Merged
Conversation
It streams test progress while the tests run, which the test report is about to use, and runs the tests with Orchard's new orchard.test.
The test report renders each var's non-passing assertions and unescapes newlines over the whole buffer in one go. Pulling both into helpers lets the failures of a run in progress be appended to the report the same way.
With cider-test-stream-results on (the default), test requests ask cider-nrepl to stream its progress. The echo area then shows the running totals after each test var, and a failing var is added to the test report as soon as it's done, so it can be looked at while the rest of the run continues. The final report replaces that buffer's contents without popping it up again. A cider-nrepl without streaming ignores the request, and the report arrives at the end as before.
insert-rectangle pushes the mark, so rendering each expected/actual value echoed "Mark set" and buried the run's summary in the echo area.
bbatsov
force-pushed
the
stream-test-results
branch
from
October 2, 2026 11:05
744983b to
62f3e66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failures show up in the test report as each var finishes, and the echo area keeps a running count, instead of everything arriving when the run is over. The streaming comes from cider-nrepl 0.63.0 (clojure-emacs/cider-nrepl#1051), which is now the injected version; with an older cider-nrepl nothing changes.
Also stops the report from echoing "Mark set" for every expected/actual value it renders, which buried the run summary.
Fixes #696