fix(client): guard syncRepository against cleared selectedRepo after await - #2603
Merged
Conversation
Contributor
|
🤖 Hey ! A preview of the application is available at : https://console-pr-2603.dso.cpin-hp.numerique-interieur.fr Please be patient, deployment may take a few minutes. |
StephaneTrebel
approved these changes
Sep 7, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 7, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 7, 2026
shikanime
force-pushed
the
fix/repo-sync-selectedrepo-race
branch
from
September 7, 2026 16:23
79d3e0e to
32c2006
Compare
shikanime
enabled auto-merge
September 7, 2026 16:23
shikanime
disabled auto-merge
September 8, 2026 07:46
shikanime
enabled auto-merge
September 8, 2026 07:46
…await Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: I6faf7012b6113dbdadf4f952023c73a46a6a6964
shikanime
force-pushed
the
fix/repo-sync-selectedrepo-race
branch
from
September 8, 2026 07:48
32c2006 to
6eee69a
Compare
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (24.80% Estimated after merge)
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 8, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 8, 2026
2 tasks
Member
Author
|
La CI de branche de cette PR est verte (run 34201179018). Les échecs |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
Issues numéro:
Quel est le comportement actuel ?
Le snackbar affiche
can't access property "internalRepoName", h.value is undefinedau lancement d'une synchronisation de dépôt si la modale est fermée pendant l'appel (save / delete / reload) :selectedRepoest vidé, etsyncRepository()litselectedRepo.value.internalRepoNameaprès l'await deRepositories.sync(...).Quel est le nouveau comportement ?
syncRepository()figeconst repo = selectedRepo.valueavant l'await et utilise cette référence pour.idet.internalRepoName. Aucun accès post-await sur une référence volatile ; plus de TypeError en snackbar.Cette PR introduit-elle un breaking change ?
Non.
Autres informations
Fichier modifié :
apps/client/src/components/ProjectResources.vue—syncRepository()