fix(server-nestjs): make Nexus create paths idempotent - #2627
Merged
Conversation
shikanime
force-pushed
the
fix/nexus-create-idempotent
branch
2 times, most recently
from
August 28, 2026 14:20
d017f6a to
77bceb6
Compare
shikanime
commented
Aug 31, 2026
shikanime
left a comment
shikanime
left a comment
Member
Author
There was a problem hiding this comment.
Verdict : Changements demandés — la PR ne compile pas (PR propriétaire : commentaire bloquant, non request-changes).
La logique d idempotence des méthodes ensure* est correcte, mais la PR supprime l import de NexusError (lignes 1-4) tout en continuant à l utiliser dans isAlreadyExistsError (lignes 347-348). tsc échouera donc sur NexusError non déclaré.
- nexus-client.service.ts:1-4,347-348 — [🔴 Bloquant]
NexusErrorest référencé dansisAlreadyExistsErrormais n est plus importé (l edit retireimport { NexusError } from "./nexus-http-client.service"). Suggestion : remettreimport { NexusError, NexusHttpClientService } from "./nexus-http-client.service". - nexus.utils.ts / gitlab.utils.ts / vault.utils.ts — [🟠 Important] Les gardes
isVaultNotFound/isVaultBadRequest/isNexusNotFound/isGitbeakerUnauthorizedsont déjà fusionnées surmain(ec9c18a914). Cette PR les re-implémente : rebasez surmainpour ne garder que la logiqueensure*, sinon conflit garanti (voir #2626 CONFLICTING). - nexus-client.service.ts:347-350 — [🟡 Nit]
isAlreadyExistsErrorne traite que les 4xx ; un test sur le casstatus:undefinedmanque.
✨ Le motif ensure* + relecture existant sur 409/already-exists couvre tous les chemins de création Nexus. Rebasez sur main et corrigez l import avant de sortir du draft.
shikanime
force-pushed
the
fix/nexus-create-idempotent
branch
from
August 31, 2026 11:44
77bceb6 to
a1fb59c
Compare
…tolerance) Refs #2619 Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: I7119237dea4827b8ea5a8ed631d47c1d6a6a6964
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: I2796efd52dbe032751eb5a313aeede8a6a6a6964
shikanime
force-pushed
the
fix/nexus-create-idempotent
branch
from
September 1, 2026 11:26
a1fb59c to
ff3fd2a
Compare
shikanime
marked this pull request as ready for review
September 1, 2026 11:30
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
This was referenced Sep 1, 2026
StephaneTrebel
approved these changes
Sep 7, 2026
Contributor
|
🤖 Hey ! A preview of the application is available at : https://console-pr-2627.dso.cpin-hp.numerique-interieur.fr Please be patient, deployment may take a few minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
#2619 (fermer délibérément après la fusion)
Quel est le comportement actuel ?
Lors de la synchronisation Nexus d'un projet, chaque ressource est créée après une lecture préalable (GET puis POST). Sous synchronisations concurrentes, deux exécutions peuvent valider la lecture puis l'écriture perdante échoue avec un NexusError (statut 409 ou message évoquant une ressource déjà présente), interrompant toute la synchronisation du projet.
Comportement attendu
La création concurrente d'une ressource déjà présente ne doit plus interrompre la synchronisation : le client récupère la ressource existante et la retourne, laissant la branche de mise à jour du demandeur réconcilier l'écart au cycle suivant.
Changements