refactor(server-nestjs): split Vault makeVaultHandlers into subfunctions - #2661
Closed
shikanime wants to merge 4 commits into
Closed
refactor(server-nestjs): split Vault makeVaultHandlers into subfunctions#2661shikanime wants to merge 4 commits into
shikanime wants to merge 4 commits into
Conversation
Vault testing utils use @msw/data Collection for faker-seeded secret engines and secrets. Server initialized empty, handlers added in beforeEach. Refs #2655 Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: Shikanime Deva <william.phetsinorath@shikanime.studio> Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: I1ed87e505cc5a57922bdc0fa62621c596a6a6964
Registry testing utils use @msw/data Collection for faker-seeded Harbor projects, robots, quotas, members, repositories. Handlers split into per- resource subfunctions. makeRobotPermissions() extracted as factory. Refs #2655 Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: Shikanime Deva <william.phetsinorath@shikanime.studio> Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: I3040943080a743eb0d3e5a55f782a9766a6a6964
Split makeNexusHandlers into per-resource subfunctions for readability: - makeNexusRepositoriesHandlers (maven/npm hosted + group CRUD) - makeNexusPrivilegesHandlers - makeNexusRolesHandlers - makeNexusSecurityHandlers Refs #2655 Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: Shikanime Deva <william.phetsinorath@shikanime.studio> Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: I874229d36d4916baa5bc056f3c2c62886a6a6964
Split makeVaultHandlers into per-resource subfunctions for readability: - makeVaultKvHandlers (kv read/write/metadata/list) - makeVaultSysHandlers (policies, mounts, approle, auth methods) - makeVaultIdentityHandlers (identity group CRUD) - makeVaultTokenHandlers (token creation) Preserve existing factory functions: makeProjectWithDetails, makeZoneWithDetails, makeVaultSecret, makeVaultSecretMetadata Refs #2655 Co-authored-by: Automata <automata@shikanime.studio> Signed-off-by: Shikanime Deva <william.phetsinorath@shikanime.studio> Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr> Change-Id: If9d9d123a0a479f6ae769647190c1bca6a6a6964
shikanime
force-pushed
the
test/msw-vault-refactor
branch
from
September 3, 2026 13:19
5ec7d67 to
ed7f557
Compare
Member
Author
|
Closing to recreate with correct base after PR split |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split
makeVaultHandlersinto per-resource subfunctions for readability:makeVaultKvHandlers— kv read/write/metadata/listmakeVaultSysHandlers— policies, mounts, approle, auth methodsmakeVaultIdentityHandlers— identity group CRUDmakeVaultTokenHandlers— token creationPreserves existing factory functions:
makeProjectWithDetails,makeZoneWithDetails,makeVaultSecret,makeVaultSecretMetadata.Refs #2656
Co-authored-by: Automata automata@shikanime.studio
Signed-off-by: Shikanime Deva william.phetsinorath@shikanime.studio