fix(deployment): send value source paths to ArgoCD without <env> substitution - #2699
Merged
Merged
Conversation
4 tasks
KepoParis
force-pushed
the
feat/2683-remove-env-pattern-substitution
branch
from
September 8, 2026 13:56
9771b7b to
e1b9842
Compare
shikanime
approved these changes
Sep 8, 2026
shikanime
requested changes
Sep 8, 2026
shikanime
left a comment
shikanime
left a comment
Member
There was a problem hiding this comment.
Ca va pas peter les env/depots d'avant ?
shikanime
approved these changes
Sep 8, 2026
shikanime
left a comment
shikanime
left a comment
Member
There was a problem hiding this comment.
nvm, c'est une autre fonction, all good
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
Issues numéro: #2683
Quel est le comportement actuel ?
Le motif
<env>d'un chemin de values de déploiement est remplacé par le nom de l'environnement à la génération des sources ArgoCD.Quel est le nouveau comportement ?
Le chemin part tel quel vers ArgoCD. Le placeholder et le hint du formulaire ne mentionnent plus le motif.
Les nouveaux objets déploiement ne supportent pas la substitution
<env>, ni maintenant ni plus tard. Chaque source de values doit pointer vers un chemin littéral.Le formulaire de dépôt (
helmValuesFilesdes dépôts d'infra) garde la substitution pour l'existant.Cette PR introduit-elle un breaking change ?
Oui pour les sources de values de déploiement qui utilisaient
<env>: le chemin doit être écrit en littéral.Autres informations
Nouveau test dans
argocd.service.spec.tsvérifiant que<env>arrive intact dansvalueFiles.