Skip to content

fix: OpenCDS should have been enabled though plugin service not from main - #2703

Merged
StephaneTrebel merged 1 commit into
mainfrom
wphetsinorath/push-wsqkvrotqnko
Sep 9, 2026
Merged

fix: OpenCDS should have been enabled though plugin service not from main#2703
StephaneTrebel merged 1 commit into
mainfrom
wphetsinorath/push-wsqkvrotqnko

Conversation

@shikanime

Copy link
Copy Markdown
Member

Issues liées

#2702


Quel est le comportement actuel ?

ServiceChainModule est importé et activé directement dans MainModule (apps/server-nestjs/src/main.module.ts) : le module des chaînes de services OpenCDS est chargé par le serveur NestJS indépendamment du plugin OpenCDS.

Quel est le nouveau comportement ?

ServiceChainModule n'est plus activé depuis MainModule : l'activation des chaînes de services OpenCDS relève du plugin via le service de plugins.

Cette PR introduit-elle un breaking change ?

Non.

Autres informations

Correctif limité à la suppression de l'import de ServiceChainModule dans apps/server-nestjs/src/main.module.ts (2 lignes).

…main

Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
Change-Id: I379f48b69cfbac57e8e7b6d0cc78ca0f6a6a6964
@shikanime shikanime self-assigned this Sep 8, 2026
@shikanime shikanime added the bug Something isn't working label Sep 8, 2026
@shikanime shikanime added this to the 9.25.2 milestone Sep 8, 2026
@shikanime shikanime added the preview Deploy preview app with Argo-cd label Sep 8, 2026
@shikanime
shikanime marked this pull request as ready for review September 8, 2026 18:16
@shikanime
shikanime requested a review from a team as a code owner September 8, 2026 18:16
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Hey !

A preview of the application is available at : https://console-pr-2703.dso.cpin-hp.numerique-interieur.fr

Please be patient, deployment may take a few minutes.

@shikanime
shikanime enabled auto-merge September 8, 2026 18:17
@github-actions github-actions Bot added the built label Sep 8, 2026
@cloud-pi-native-sonarqube

Copy link
Copy Markdown

@shikanime
shikanime added this pull request to the merge queue Sep 8, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 8, 2026
@StephaneTrebel
StephaneTrebel added this pull request to the merge queue Sep 9, 2026
Merged via the queue into main with commit 2967d92 Sep 9, 2026
64 checks passed
@StephaneTrebel
StephaneTrebel deleted the wphetsinorath/push-wsqkvrotqnko branch September 9, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working built preview Deploy preview app with Argo-cd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants