Skip to content

fix(client): clarify values file path hint per value source type #2715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KepoParis merged 1 commit into from
Sep 10, 2026
+8 −1
Merged

fix(client): clarify values file path hint per value source type #2715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion apps/client/src/components/DeploymentValueSourceOption.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,13 @@ type ValueSourcePatch = Partial<Pick<Extract<UpdateDeploymentValueSource, { type
function update(patch: ValueSourcePatch): void {
model.value = { ...model.value, ...patch }
}

// An internal source lives in the deployed repository: its path is resolved from the
// deployed directory, like the legacy value files. An external source points to another
// repository, whose root is the only reference available.
const pathHint = computed(() => model.value.type === 'external'
? 'Chemin du fichier relatif à la racine du dépôt de valeurs sélectionné.'
: 'Chemin du fichier relatif au répertoire à déployer.')
</script>

<template>
Expand Down Expand Up @@ -137,7 +144,7 @@ function update(patch: ValueSourcePatch): void {
label="Chemin du fichier de valeurs"
label-visible
placeholder="values.yaml"
hint="Chemin du fichier relatif à la racine du dépôt."
:hint="pathHint"
required
:disabled="props.disabled"
:error-message="props.isDirty && !model.path ? 'Le chemin du fichier est requis' : undefined"
Expand Down