Add suse network config support#452
Merged
petrutlucian94 merged 2 commits intoJul 8, 2026
Merged
Conversation
mihaelabalutoiu
force-pushed
the
add-suse-network-config-support
branch
2 times, most recently
from
9afb3e3 to
918f222
Compare
Dany9966
requested changes
Jul 2, 2026
mihaelabalutoiu
force-pushed
the
add-suse-network-config-support
branch
from
918f222 to
6d19fac
Compare
Dany9966
requested changes
Jul 3, 2026
mihaelabalutoiu
force-pushed
the
add-suse-network-config-support
branch
from
6d19fac to
1d7999b
Compare
Member
Author
|
I made the changes, please take a look now. Thank you! |
Dany9966
requested changes
Jul 3, 2026
mihaelabalutoiu
force-pushed
the
add-suse-network-config-support
branch
from
1d7999b to
387c973
Compare
Contributor
|
LGTM |
| 'mv "%s" "%s%s"' % (cfg_path, cfg_path, backup_file_suffix)) | ||
| LOG.debug("Backed up ifcfg profile '%s'", cfg_path) | ||
|
|
||
| def _write_nic_configs(self, nics_info): |
Member
There was a problem hiding this comment.
I see that the nics_info format is entirely provider specific, all we need is the number of nics:
coriolis/coriolis/schemas/os_morphing_resources_schema.json
Lines 38 to 43 in 7ea1e24
I guess it's reasonable since providers can override this and handle provider specific nic info.
Member
|
Oh, and please add a PR description. |
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
mihaelabalutoiu
force-pushed
the
add-suse-network-config-support
branch
from
387c973 to
0458a90
Compare
Member
Author
Done, I updated the code, please take a look now and sorry about that. |
petrutlucian94
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds:
SLES 16).set_net_configanddisable_predictable_nic_namesfor SUSE, with support for both wicked-based (SLES/openSUSE 12/15) andNetworkManager-based(SLES 16) systems.ifcfg/NetworkManagerconfiguration logic into the shared base class, reducing code duplication and ensuring existing network profiles are backed up before new ones are written.