Finish proxy support#822
Merged
gabriel-samfira merged 1 commit intoJul 9, 2026
Merged
Conversation
Well, this turned out to be a massive change, but most of it is scaffolding needed to add a new DB entity. There are several layers of CRUD (db, runner package, API, CLI, webapp), types that need to get added and which generate client code, cache worker to hook up, etc. The goal of this change is to add actual Proxy support to GARM at all levels: * GARM itself (when contacting the forge/IAAS) * runner instances - userdata (install script, package manager) * runner instances - the actual runner service At each level, and for each forge...and for each OS the proxy settings have a different way of being set. Hopefully this change covers them all. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well, this turned out to be a massive change, but most of it is scaffolding needed to add a new DB entity. There are several layers of CRUD (db, runner package, API, CLI, webapp), types that need to get added and which generate client code, cache worker to hook up, etc.
The goal of this change is to add actual Proxy support to GARM at all levels:
At each level, and for each forge...and for each OS the proxy settings have a different way of being set. Hopefully this change covers them all.
There is now a new
proxysubcommand in the CLI and a dedicatedProxysection in the webapp:Multiple proxies can be defined in GARM, with or without credentials. After defining a proxy, you may set it on a pool or scale set. You may define multiple proxies and set whichever proxy is appropriate for a particular network.
Fixes #438