fix: resolve node-pty reliably in web terminal plugin#7
Open
LimLLL wants to merge 1 commit intocloudcli-ai:mainfrom
Open
fix: resolve node-pty reliably in web terminal plugin#7LimLLL wants to merge 1 commit intocloudcli-ai:mainfrom
LimLLL wants to merge 1 commit intocloudcli-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes runtime startup failures for the Web Terminal plugin when
node-ptyis not resolved from the plugin'sdistdirectory or when CloudCLI is installed globally.What changed
node-ptyto1.2.0-beta.12for better Node 22 compatibility.node-ptyandws.dist/node_modulesnode_modulesMODULE_NOT_FOUNDerrors, so native module load failures are surfaced correctly.node-ptyspawn-helperexecute permissions.Why
In Docker/self-hosted CloudCLI environments, the plugin can fail to start with:
Installing dependencies in the plugin root may not always help because the plugin server is launched from
dist/server.js, and the old resolver could hide the real failure reason.Verification
Tested locally with:
The plugin server starts successfully and prints:
{"ready":true,"port":45067}Notes
This also includes the macOS
spawn-helperpermission self-healing behavior from the existing open PR, but the main motivation here is Linux Docker / Node 22 module resolution reliability.