Add NoFlushPanicIntegration for sentry#211
Merged
Merged
Conversation
sentry's built-in panic handler integration explicitly flushes each event it generates. This makes sense as a default: a double-panic aborts the process, which would cause sentry event for the initial panic to be lost. However, it significantly increases the wall-clock duration of the panic handler if flushing means sending an HTTP request to a remote sentry server. `NoFlushPanicIntegration` uses `sentry-panic`'s public API to generate the exact same panic events as sentry's built-in handler, but does not flush to speed up panic handler processing. This is preferrable for services where panics are caught and contained, for example in an HTTP server's request handler.
Collaborator
Author
|
cc @gregor-cf |
fisherdarling
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sentry's built-in panic handler integration explicitly flushes each event it generates. This makes sense as a default: a double-panic aborts the process, which would cause sentry event for the initial panic to be lost. However, it significantly increases the wall-clock duration of the panic handler if flushing means sending an HTTP request to a remote sentry server.
NoFlushPanicIntegrationusessentry-panic's public API to generate the exact same panic events as sentry's built-in handler, but does not flush to speed up panic handler processing. This is preferrable for services where panics are caught and contained, for example in an HTTP server's request handler.