Conversation
commit: |
Docs PreviewCommit: |
📐 Bundle SizeConsumer fixtures bundled against
npm tarball: 518 files, 1.45 MB packed, 6.80 MB unpacked.
|
|
/bonk review this |
|
After reviewing the changes, I found 2 actionable issues introduced by this PR. 1. Missing keyboard activation for focusable SVG paths (WCAG violation) The interactive region and marker
Fix: Add 2. The
Fix: Remove These are the only material issues I found. The implementation is otherwise solid: the dot cache, WeakMap, compound path, and frame-coalesced drag updates are well done, semantic tokens are used correctly, and the performance claims in the description are reflected in the code. |
|
/bonk i think those are fixed can you give it another once over? |
|
The previous two issues have been addressed:
I also verified:
No new material issues found. LGTM! |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://the-globe-kumo-docs.design-engineering.workers.dev (commit dcac81d)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
|
/bonk review the new implementation that uses d3-geo |
|
After reviewing the d3-geo-based 1. Pointer capture on the SVG breaks marker
Fix: Skip capture when the const target = event.target as Element;
if (target.closest("circle[role='button']")) return;Add a test that clicks a marker (e.g., 2. All other chart components ( Fix: Wrap the component with 3. Focus tooltip is centered on the SVG instead of on the focused marker In the marker's Fix: Use the marker's projected Minor suggestion (non-blocking): |
|
/bonk updated, please re-review. |
|
All three issues from the previous review have been fixed, and the non-blocking suggestion was applied as well. I don't see any new material issues introduced by these changes. Verified fixes:
Also confirmed:
LGTM! |

























































What changed
Adds a reusable
GlobeMapto Kumo. I kept the scope to the dotted globe for now and removed the choropleth/boundary version.The docs example uses Cloudflare availability locations and matches the globe style from the marketing site.
Perf
I reworked the land rendering around a fixed dot lattice and a rotating land mask. The dots stay in place and land membership is updated as the globe rotates, which keeps the pattern dense and avoids pushing rotation through React every frame.
Testing
added rendering, density, drag, horizon fade, and keyboard interaction coverage
typecheck, focused tests, lint, package build, publint, ATTW, and docs typecheck pass
manually checked the globe while rotating in the docs
Reviews
bonk has reviewed the change
automated review not possible because: the globe needed interactive and visual review
Tests
Tests included/updated
Automated tests not possible - manual testing has been completed as follows: not applicable
Additional testing not necessary because: not applicable