[kumo] remove inherited ghost button background - #770
Open
ftzi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ghost buttons are documented as having no background, but
bg-inheritpaints the parent background inside the button. On translucent surfaces, this composites the alpha color twice and creates a darker local fill.This removes the resting background utility while retaining
hover:bg-kumo-tint. It also adds a focused regression test for the variant class contract.Shadcn use this same no-bg-classname pattern for its ghost variant.
Verification:
pnpm --filter @cloudflare/kumo exec vp test run --project=unit src/components/button/button.test.tsxpnpm --filter @cloudflare/kumo buildpnpm run testpnpm run lintpnpm run typecheckpnpm run format:checkAI disclosure: This change, test, changeset, and pull request description were prepared by an AI coding agent under contributor direction.