Skip to content

[kumo] remove inherited ghost button background - #770

Open
ftzi wants to merge 1 commit into
cloudflare:mainfrom
ftzi:fix/ghost-button-background
Open

[kumo] remove inherited ghost button background#770
ftzi wants to merge 1 commit into
cloudflare:mainfrom
ftzi:fix/ghost-button-background

Conversation

@ftzi

@ftzi ftzi commented Sep 2, 2026

Copy link
Copy Markdown

Ghost buttons are documented as having no background, but bg-inherit paints the parent background inside the button. On translucent surfaces, this composites the alpha color twice and creates a darker local fill.

This removes the resting background utility while retaining hover:bg-kumo-tint. It also adds a focused regression test for the variant class contract.

Shadcn use this same no-bg-classname pattern for its ghost variant.

Verification:

  • pnpm --filter @cloudflare/kumo exec vp test run --project=unit src/components/button/button.test.tsx
  • pnpm --filter @cloudflare/kumo build
  • pnpm run test
  • pnpm run lint
  • pnpm run typecheck
  • pnpm run format:check

AI disclosure: This change, test, changeset, and pull request description were prepared by an AI coding agent under contributor direction.


  • Reviews
    • bonk has reviewed the change
    • automated review not possible because: the repository's automated reviewer runs after pull request submission
  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant