Skip to content

chore: bump pnpm to v12 - #794

Merged
rozenmd merged 4 commits into
mainfrom
rozenmd/bump-pnpm-v12
Sep 10, 2026
Merged

chore: bump pnpm to v12#794
rozenmd merged 4 commits into
mainfrom
rozenmd/bump-pnpm-v12

Conversation

@rozenmd

@rozenmd rozenmd commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • pin pnpm 12.3.4 for local and CI installs
  • update Vite+ to 0.3.1 for pnpm 12 package-manager support
  • migrate the removed onlyBuiltDependencies setting to the pnpm 12 allowBuilds policy
  • update the lockfile and apply the new formatter output

Validation

  • vp install --frozen-lockfile

  • pnpm typecheck

  • pnpm test (1,308 tests)

  • pnpm lint

  • pnpm format:check

  • Reviews

  • bonk has reviewed the change

  • automated review not possible because: this is a toolchain migration with generated lockfile and formatter output

  • Tests

  • Tests included/updated

  • Automated tests not possible - manual testing has been completed as follows: not applicable

  • Additional testing not necessary because: the existing install, typecheck, test, lint, and format checks cover this migration

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 10, 2026

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://rozenmd-bump-pnpm-v12-kumo-docs.design-engineering.workers.dev (commit c1b64cb)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://e541ed9a-kumo-docs.design-engineering.workers.dev c1b64cb 2026-09-10T11:53:58.864Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://2ab286c4-kumo-docs.design-engineering.workers.dev 71f7ea0 2026-09-10T11:46:02.458Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://cb453c4f-kumo-docs.design-engineering.workers.dev 18e1c23 2026-09-10T11:39:41.586Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://0e42d285-kumo-docs.design-engineering.workers.dev 844af54 2026-09-10T11:27:59.721Z Visit the dashboard ↗

Comment thread pnpm-workspace.yaml Outdated
@ask-bonk

ask-bonk Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

I'm Bonk, and I've done a quick review of your PR.

1 finding posted inline.

Review notes
  • Confirming PR chore: bump pnpm to v12 #794 and inspecting its existing reviews, changed configuration, lockfile changes, and applicable workspace guidance.
  • Verified the target is PR chore: bump pnpm to v12 #794 at the supplied head commit, with no prior reviews. The configuration diff is whitespace-clean; next I am checking all package-manager installation paths and the lockfile's pnpm-12 migration records.
  • The review environment has neither pnpm nor Node installed, so install/test commands cannot run. I found that pnpm 12 records the package-manager dependency as a separate YAML document at the start of the lockfile; I am verifying this new lockfile format and the build-approval policy against pnpm's documentation and the resolved dependency metadata.
  • Verified pnpm 12's documented two-document lockfile format: the added env document correctly pins pnpm@12.3.4. The allowBuilds map preserves the former allow-only policy by allowing workerd and explicitly denying the four other dependency build scripts present in the resolved graph.
  • GitHub checks show the install-dependent jobs failing before lint, typecheck, and test run, while static lockfile-structure checks pass locally. I am inspecting the failed CI logs to determine whether the pnpm migration causes the shared setup failure.
  • CI logs confirm every install-dependent job fails at vp install --frozen-lockfile with Cannot find binary path for command 'pnpm'. Setup recognizes pnpm 12.3.4 but Vite+ 0.2.6 cannot execute it, so the migration currently blocks the PR's build, docs, preview, format, and changeset workflows.
  • Upstream Vite+ 0.2.7 specifically adds support for pnpm 12's native binary distribution; this repository remains pinned to 0.2.6. I will post one inline suggestion on that pin, which addresses the confirmed CI failure.
  • Posted one inline suggestion on pnpm-workspace.yaml; it upgrades the Vite+ pin required for pnpm 12 CI installs.

github run

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor
Visual Regression Report — 18 changed, 27 unchanged

18 screenshot(s) with visual changes:

Button / Loading State

32 px (0.04%) changed

Before After Diff
Before After Diff

Dialog / Dialog Sizes

964 px (1.09%) changed

Before After Diff
Before After Diff

Dialog / Dialog Alert

1,169 px (1.32%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Select

383 px (0.43%) changed

Before After Diff
Before After Diff

Dialog (Open)

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select Sizes

2,862 px (1.76%) changed

Before After Diff
Before After Diff

Select / Select Placement

4,303 px (2.97%) changed

Before After Diff
Before After Diff

Select / Select Dynamic Placement

2,608 px (2.51%) changed

Before After Diff
Before After Diff

Select / Select Without Label

758 px (0.86%) changed

Before After Diff
Before After Diff

Select / Select With Description

1,687 px (1.62%) changed

Before After Diff
Before After Diff

Select / Select With Tooltip

196 px (0.22%) changed

Before After Diff
Before After Diff

Select / Select Custom Rendering

739 px (0.83%) changed

Before After Diff
Before After Diff

Select / Select Loading

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select Multiple

1,265 px (1.43%) changed

Before After Diff
Before After Diff

Select / Select Grouped

708 px (0.8%) changed

Before After Diff
Before After Diff

Select / Select Grouped With Disabled

190 px (0.21%) changed

Before After Diff
Before After Diff

Select / Select Long List

163 px (0.16%) changed

Before After Diff
Before After Diff

Select (Open)

0 px (0%) changed

Before After Diff
Before After Diff
27 screenshot(s) unchanged
  • Button / Basic
  • Button / Variant: Primary
  • Button / Variant: Secondary
  • Button / Variant: Ghost
  • Button / Variant: Destructive
  • Button / Variant: Outline
  • Button / Variant: Secondary Destructive
  • Button / Sizes
  • Button / With Icon
  • Button / Icon Only
  • Button / Disabled State
  • Button / Title
  • Button / Link as Button
  • Button / Link with Tooltip
  • Button / Disabled Link
  • Dialog / Dialog With Actions
  • Dialog / Dialog Basic
  • Dialog / Dialog Confirmation
  • Dialog / Custom Max Width
  • Dialog / Dialog With Combobox
  • Dialog / Dialog With Dropdown
  • Select / Select Basic
  • Select / Select With Error
  • Select / Select Placeholder
  • Select / Select Complex
  • Select / Select Disabled Options
  • Select / Select Disabled Items

Generated by Kumo Visual Regression

@pkg-pr-new

pkg-pr-new Bot commented Sep 10, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/kumo@794

commit: c1b64cb

@rozenmd

rozenmd commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator Author

/bonk mind re-reviewing

@ask-bonk

ask-bonk Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

LGTM!

Review notes
  • Reviewing PR chore: bump pnpm to v12 #794 at its current head. The prior Vite+ compatibility finding has been addressed by the updated 0.3.1 pins; I’m now checking the complete changed configuration and lockfile resolution.
  • I verified the prior inline comment is stale and no additional reviews were published. The current workspace policy explicitly allows only workerd builds and denies the other dependency scripts; the required Kumo changeset is present.
  • The regenerated lockfile contains pnpm 12’s package-manager dependency document, resolves the Vite+ 0.3.1 toolchain consistently across all importers, and has no whitespace errors. CI’s format and changeset jobs now pass; the remaining build and docs jobs are still in progress.
  • Corepack resolved the declared pnpm 12.3.4 binary, and pnpm install --lockfile-only --frozen-lockfile --ignore-scripts passed its 1,248-entry supply-chain-policy validation without changing the lockfile. The CI build job has also passed; no actionable regressions found.

github run

@github-actions

Copy link
Copy Markdown
Contributor

📐 Bundle Size

Consumer fixtures bundled against packages/kumo/dist (peers external, minified ESM).

Fixture Raw Gzip Brotli
Button (root) 174.6 KB 49.9 KB 43.1 KB
Button (components/button) 174.5 KB 49.9 KB 43.0 KB
Button + Dialog + Select (root) 299.5 KB 85.8 KB 71.8 KB
Button + Dialog + Select (component subpaths) 299.5 KB 85.9 KB 71.8 KB
Chart (root) 218.6 KB 63.4 KB 54.7 KB
Chart (components/chart) 218.5 KB 63.3 KB 54.7 KB
Badge (components/badge) 44.7 KB 11.7 KB 10.0 KB
Flow (components/flow) 208.9 KB 58.3 KB 50.5 KB
Button (primitives/button) 12.2 KB 4.4 KB 3.9 KB
Primitives barrel 635.7 KB 176.9 KB 139.3 KB
Code highlighting (code) 2.08 MB 467.9 KB 349.2 KB

npm tarball: 528 files, 1.45 MB packed, 6.78 MB unpacked.

⚠️ 22 flagged files in tarball (tests / raw scripts)
  • dist/blocks-source/resource-list/resource-list.test.tsx
  • scripts/component-registry/cache.ts
  • scripts/component-registry/discovery.ts
  • scripts/component-registry/example-cleanup.ts
  • scripts/component-registry/index.test.ts
  • scripts/component-registry/index.ts
  • scripts/component-registry/markdown-generator.ts
  • scripts/component-registry/metadata.ts
  • scripts/component-registry/props-filter.ts
  • scripts/component-registry/schema-generator.ts
  • scripts/component-registry/sub-components.ts
  • scripts/component-registry/types.ts
  • scripts/component-registry/utils.ts
  • scripts/component-registry/variant-parser.ts
  • scripts/css-build.ts
  • scripts/generate-primitives.ts
  • scripts/theme-generator/config.ts
  • scripts/theme-generator/generate-css.test.ts
  • scripts/theme-generator/generate-css.ts
  • scripts/theme-generator/index.ts
  • scripts/theme-generator/migrate.ts
  • scripts/theme-generator/types.ts

Report-only: no size thresholds are enforced yet.

Commit: c1b64cb0

@rozenmd
rozenmd merged commit 6e7bd82 into main Sep 10, 2026
18 checks passed
@rozenmd
rozenmd deleted the rozenmd/bump-pnpm-v12 branch September 10, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants