Skip to content

fix: replace corepack with pnpm - #795

Merged
rozenmd merged 3 commits into
mainfrom
rozenmd/remove-corepack
Sep 10, 2026
Merged

fix: replace corepack with pnpm#795
rozenmd merged 3 commits into
mainfrom
rozenmd/remove-corepack

Conversation

@rozenmd

@rozenmd rozenmd commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Fixes #[insert GH or internal issue link(s)].

Describe your change...


  • Reviews
    • bonk has reviewed the change
    • automated review not possible because:
  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:

@rozenmd
rozenmd requested a review from stritt September 10, 2026 13:38
@ask-bonk

ask-bonk Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

LGTM!

Review notes
  • Confirmed the review target is cloudflare/kumo PR fix: replace corepack with pnpm #795, “fix: replace corepack with pnpm”. I’ll inspect the PR diff, package metadata, lockfile changes, and existing reviews before deciding whether inline feedback is warranted.
  • The checked-out commit matches the requested head SHA, and PR fix: replace corepack with pnpm #795 has no existing reviews or comments. The local clone has no origin/main ref, so I’m comparing the PR commit directly with its parent and checking the generated lockfile entries.
  • The complete two-file diff is whitespace-clean. It removes the legacy packageManager pin, changes devEngines.packageManager.onFail to download, and updates the environment-lock document with the pnpm executable; this matches pnpm 12’s documented mechanism for version-managed package managers.
  • The installed runner image does not include pnpm, so an install validation cannot run locally. I’m checking the repository’s dependency-install action and workflow callers to ensure they bootstrap a compatible pnpm version before relying on this manifest.
  • CI bootstraps Node from .node-version through voidzero-dev/setup-vp and runs every install as vp install --frozen-lockfile; all workflow callers use this composite action. The manifest’s pnpm 12 download policy and lockfile pin are therefore applied by the supported package-manager path.
  • I found no actionable regression in the changed manifest or lockfile. I’ll perform a final check of the PR’s reported workflow status; no inline review will be submitted unless that identifies a change-related failure.
  • The final metadata check confirms the reviewed commit and diff are clean. CodeQL and changeset checks have passed; the package/docs workflow checks are still pending. A separate external Workers Builds: kumo-docs check is failing with no GitHub-exposed diagnostic output, so I’m inspecting its check-run metadata to determine whether it is attributable to this dependency-bootstrap change.

github run

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 10, 2026

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://rozenmd-remove-corepack-kumo-docs.design-engineering.workers.dev (commit 5f73124)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://d1c4c031-kumo-docs.design-engineering.workers.dev 5f73124 2026-09-10T13:45:51.018Z Visit the dashboard ↗

@pkg-pr-new

pkg-pr-new Bot commented Sep 10, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/kumo@795

commit: 5f73124

@rozenmd
rozenmd merged commit 1e541b3 into main Sep 10, 2026
18 checks passed
@rozenmd
rozenmd deleted the rozenmd/remove-corepack branch September 10, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants