style(layer-dialog): refine dialog surfaces - #796
Merged
mattrothenberg merged 2 commits intoSep 10, 2026
Merged
Conversation
commit: |
Contributor
Docs PreviewCommit: |
Contributor
Contributor
📐 Bundle SizeConsumer fixtures bundled against
npm tarball: 535 files, 1.47 MB packed, 6.84 MB unpacked.
|
mattrothenberg
merged commit Sep 10, 2026
f4d2141
into
cloudflare:feat/strict-layer-dialog
12 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



















































Summary
Follow-up to #793.
Validation
pnpm --filter @cloudflare/kumo buildpnpm --filter @cloudflare/kumo typecheckpnpm --filter @cloudflare/kumo exec vp test run --project=unit src/components/layer-dialog/layer-dialog.test.tsxpnpm --filter @cloudflare/kumo-docs-astro typecheckpnpm --filter @cloudflare/kumo lintReviews
bonk has reviewed the change
automated review not possible because: final visual judgment requires human design review
Tests
Tests included/updated
Automated tests not possible - manual testing has been completed as follows: reviewed all LayerDialog demos locally
Additional testing not necessary because: behavior is unchanged and existing LayerDialog tests pass