Conversation
Contributor
|
LGTM |
Contributor
|
LGTM from the Workflows team |
Naapperas
force-pushed
the
workflows-create-batch-overload
branch
from
September 8, 2026 11:47
8477464 to
8faf87f
Compare
penalosa
approved these changes
Sep 8, 2026
penalosa
left a comment
penalosa
left a comment
Contributor
There was a problem hiding this comment.
Stamping from a types perspective (this still needs a runtime review).
Do you have a draft change ready to add this to Miniflare?
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an overload to the
createBatchmethod in the Workflows binding, reflecting the new V2 API we are releasing for this method.