[wrangler] Fix running duration calculation in workflows instances describe - #15587
Open
Kuldeeep18 wants to merge 1 commit into
Open
[wrangler] Fix running duration calculation in workflows instances describe#15587Kuldeeep18 wants to merge 1 commit into
Kuldeeep18 wants to merge 1 commit into
Conversation
workers-devprod
requested review from
a team and
jamesopstad
and removed request for
a team
September 10, 2026 09:22
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
@cloudflare/containers-shared
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Kuldeeep18
force-pushed
the
fix/workflows-describe-running-duration
branch
from
September 13, 2026 15:16
2b4d221 to
09e5eb2
Compare
🦋 Changeset detectedLatest commit: 09e5eb2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When inspecting in-progress workflow instances, steps, or attempts (
end == null) withwrangler workflows instances describe, the displayedDurationwas distorted across non-UTC client timezones.For example, a step that started 10 seconds ago displayed as running for:
America/Los_Angeles(PDT)America/New_York(EDT)Asia/Kolkata(IST)Asia/Tokyo(JST)Root Cause
In
packages/wrangler/src/workflows/commands/instances/describe.ts, the current timestamp fallback for in-progress items was calculated as:Stripping
" GMT"removed the timezone identifier. When passed to JavaScript'snew Date(...), the string was parsed in the client's local timezone rather than UTC, shifting the epoch timestamp by the client'stimezoneOffset.In JavaScript,
new Date()already represents the current instant in UTC epoch milliseconds, andnew Date(start)(from an ISO 8601 UTC string) does as well.formatDistanceStrictcalculates the difference between their.getTime()values, which are timezone-independent.Solution
new Date(new Date().toUTCString().slice(0, -4))withnew Date()across instance, step, and attempt duration calculations indescribe.ts.packages/wrangler/src/__tests__/workflows.test.tsasserting exact running step and attempt duration against mocked system time.wranglerpatch release.describe.