Support V8 code coverage in the Workers Vitest integration - #15591
Open
dario-piotrowicz wants to merge 1 commit into
Open
dario-piotrowicz wants to merge 1 commit into
dario-piotrowicz wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 0a9310e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5 tasks
Contributor
|
LGTM |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
dario-piotrowicz
marked this pull request as ready for review
September 10, 2026 15:19
workers-devprod
requested review from
a team and
petebacondarwin
and removed request for
a team
September 10, 2026 15:19
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
petebacondarwin
approved these changes
Sep 14, 2026
| `, | ||
| "index.test.ts": dedent /* javascript */ ` | ||
| import { greeting } from "./src/greeting"; | ||
| import { expect, it } from "vitest"; |
Contributor
There was a problem hiding this comment.
NIT:
Fixture bypasses context-provided assertions
The new fixture imports expect from Vitest instead of using the test context. Package guidance explicitly requires context-provided assertions.
workers-devprod
approved these changes
Sep 14, 2026
workers-devprod
left a comment
workers-devprod
left a comment
Contributor
There was a problem hiding this comment.
Codeowners reviews satisfied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the v8 code coverage for the vitest plugin
Example run:
A picture of a cute animal (not mandatory, but encouraged)