[miniflare] Await workerd exit before local container cleanup - #15595
Draft
ghostwriternr wants to merge 1 commit into
Draft
ghostwriternr wants to merge 1 commit into
ghostwriternr wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: db81b9d The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Miniflare currently force-kills workerd on dispose. That is the right default for ordinary Workers, because Chrome can keep HTTP connections open for about 10s. For Durable Object containers it is wrong: workerd owns the application container and the
proxy-everythingsidecar, and it can remove them only while its Docker connection is still alive.This sends
SIGTERMwhen the serialized workerd config includes a Durable Object container, waits for the process to exit, and falls back toSIGKILLafter five seconds. Wrangler and the Vite plugin now dispose Miniflare before deleting containers by their prepared image tags.Do not merge until workers-sdk pins a workerd release that performs that sidecar cleanup. The Docker fixture asserts that both runtime containers are gone after close; that assertion is expected to fail on the current pin.