[wrangler] Guide Preview configuration onboarding - #15600
podonnell-dev merged 15 commits into
Conversation
🦋 Changeset detectedLatest commit: 4d9e0fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
b310ab2 to
34232fb
Compare
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
@cloudflare/containers-shared
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
faa1478 to
58656af
Compare
|
Codeowners approval required for this PR:
Show detailed file reviewers |
|
This is the most important part |
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Generally looks good to me, I just left some small comments here and there 🙂
Please let's fix all the typescript/eslint issues and address devin's comments too (in particular this one: #15600 (comment))
Besides that this for me is good to go 😄
|
aligning supported bindings here while fixing ai.staging validation. my general rule is: if we supported this in previews during this private beta, then it should be present (ie. no API layer changes) 2b80826 |
|
last bug 🤞 459e8c2 ignoring local config warnings if base config (settings in dashboard) are present. this was your previous point, i'm making this more explicit now |
459e8c2 to
eca9254
Compare
|
lint fix eca9254 |
|
fixing tests: f40d193 |
dario-piotrowicz
left a comment
There was a problem hiding this comment.
LGTM 😄
(Besides all the broken docs links, which seems to be expected since wrangler preview is private beta 🙂)
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Fixes WC-5927 and WC-5834.
First two commit are same as #15478 (already reviewed)
Last commit 58656af is handling previews onboarding. When a user runs
npx wrangler previewand has no local previews block, we recommend a code snippet for the user to paste into wrangler config.There are generally two paths:
We expect that regardless of where the user is coming from, they receive a configuration with REPLACE_ME placeholders. We also handle a few specific cases for user guidance
A picture of a cute animal (not mandatory, but encouraged)