[deploy-helpers] recover asset upload concurrency after gateway errors - #15631
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 5f7390f The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
dario-piotrowicz
and removed request for
a team
September 13, 2026 11:06
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
|
I'm Bonk, and I've done a quick review of your PR. Restores asset-upload concurrency gradually after gateway errors.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
@cloudflare/containers-shared
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
5 tasks
dario-piotrowicz
approved these changes
Sep 14, 2026
dario-piotrowicz
left a comment
dario-piotrowicz
left a comment
Member
There was a problem hiding this comment.
Looks good to me, with just one small suggestion regarding the test 🙂
workers-devprod
approved these changes
Sep 14, 2026
workers-devprod
left a comment
workers-devprod
left a comment
Contributor
There was a problem hiding this comment.
Codeowners reviews satisfied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #15060.
After a 524 response, the asset uploader reduces concurrency to one but never restores it. For large asset sets, a single transient gateway error can therefore serialize thousands of remaining uploads, greatly increasing deployment time and the risk of build or upload-session timeouts.
This change gradually restores the original concurrency limit after successful uploads. Recovery is generation-gated so requests already in flight when throttling occurred cannot immediately undo the backpressure. Tests cover both legacy base64 uploads and the single-file upload path.
Retry-After handling is intentionally kept out of this PR and will follow separately.
Note
This is a contribution from an AI agent: Codex (GPT-5).