Skip to content

WC-5834 [wrangler] previews: fix e2e tests - #15683

Merged
NuroDev merged 1 commit into
cloudflare:mainfrom
podonnell-dev:podonnell/fix-preview-e2e-config
Sep 16, 2026
Merged

NuroDev merged 1 commit into
cloudflare:mainfrom
podonnell-dev:podonnell/fix-preview-e2e-config

Conversation

@podonnell-dev

@podonnell-dev podonnell-dev commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Fixes WC-5834.

Fixing E2E test. Error revealed in #15657


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: non-functional
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: testing fix revealed in CI

A picture of a cute animal (not mandatory, but encouraged)


Devin Review

@changeset-bot

changeset-bot Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4cc31e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Sep 16, 2026
@workers-devprod
workers-devprod requested review from a team and NuroDev and removed request for a team September 16, 2026 18:07
@workers-devprod

workers-devprod commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@podonnell-dev podonnell-dev added the ci:e2e Run wrangler + vite-plugin E2E tests on a pull request label Sep 16, 2026
devin-ai-integration[bot]

This comment was marked as resolved.

@NuroDev
NuroDev enabled auto-merge (squash) September 16, 2026 18:09

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Sep 16, 2026
@pkg-pr-new

pkg-pr-new Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15683

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15683

@cloudflare/codemods

npm i https://pkg.pr.new/@cloudflare/codemods@15683

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15683

@cloudflare/containers-shared

npm i https://pkg.pr.new/@cloudflare/containers-shared@15683

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15683

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15683

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15683

miniflare

npm i https://pkg.pr.new/miniflare@15683

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15683

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15683

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15683

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15683

@cloudflare/vitest-plugin

npm i https://pkg.pr.new/@cloudflare/vitest-plugin@15683

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15683

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15683

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15683

wrangler

npm i https://pkg.pr.new/wrangler@15683

commit: 4cc31e8

@podonnell-dev
podonnell-dev force-pushed the podonnell/fix-preview-e2e-config branch from ff37e63 to 4cc31e8 Compare September 16, 2026 18:14
@NuroDev NuroDev added the ci:no-changeset-required Skip pull request checks for a valid changeset label Sep 16, 2026
@NuroDev
NuroDev merged commit a8d14ba into cloudflare:main Sep 16, 2026
66 of 68 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:e2e Run wrangler + vite-plugin E2E tests on a pull request ci:no-changeset-required Skip pull request checks for a valid changeset

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants