CI: stop using spot-instance BATs directors

[aramprice]

Remove preemptible: true from BATs director configurations. This flag causes GCP spot-instances to be used which are unreliable.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: aramprice / name: aram price (b2cb298)

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 258e803c-bbad-4a59-97d2-d865a9e6323b

📥 Commits

Reviewing files that changed from the base of the PR and between b147efd and b2cb298.

📒 Files selected for processing (2)

• ci/bats/iaas/gcp/director-vars
• ci/bats/iaas/gcp/prepare-bats-config.sh

💤 Files with no reviewable changes (2)

• ci/bats/iaas/gcp/prepare-bats-config.sh
• ci/bats/iaas/gcp/director-vars

---

Walkthrough

This pull request removes the preemptible: true configuration property from GCP-based BATS (Basic Acceptance Test Suite) test deployments. The change spans two related files: the prepare-bats-config.sh shell script that generates YAML configuration for GCP BATS deployments, and the director-vars file that outputs jq-generated JSON for GCP director variables. Both files previously included the preemptible VM setting, which is now removed while all other configuration properties remain intact.

Suggested reviewers

• ramonskie
• mkocher
• a-hassanin

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description provides the essential change (removing 'preemptible: true') and the reason (spot-instances are unreliable), but omits most required template sections including contextual links, testing information, release notes guidance, breaking change assessment, and team tags.	Add the missing template sections: contextual links/references, comprehensive list of tests run, release notes description for operators, breaking change assessment, and relevant team/reviewer tags.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: removing preemptible/spot-instance usage from BATs directors. It's concise, specific, and reflects the core objective of the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch stop-using-spot-instances

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Removes GCP spot/preemptible configuration from the BATs director setup to avoid unreliable spot-instance behavior in CI.

Changes:

• Remove preemptible: true from the generated BATs config YAML for GCP.
• Remove "preemptible": true from the director vars JSON produced via jq.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
ci/bats/iaas/gcp/prepare-bats-config.sh	Stops injecting preemptible: true into bats-config.yml properties for GCP BATs.
ci/bats/iaas/gcp/director-vars	Stops emitting the preemptible field in director vars JSON consumed by the GCP BATs pipeline.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[aramprice]

NOTE: EasyCLA is currently broken. See cloudfoundry/cloud_controller_ng#5089 (comment)

Re-trigger EasyCLA via:

/easycla

[lukaszgryglicki]

/easycla