Skip to content

Use subcommands with bundle config#2730

Merged
aramprice merged 1 commit intomainfrom
update-bundle-config-cmd
May 7, 2026
Merged

Use subcommands with bundle config#2730
aramprice merged 1 commit intomainfrom
update-bundle-config-cmd

Conversation

@aramprice
Copy link
Copy Markdown
Member

Future versions of bundler require bundle config {set|get|...}, not just bundle config ...

Future versions of bundler require `bundle config {set|get|...}`,
not just `bundle config ...`
Copilot AI review requested due to automatic review settings May 7, 2026 22:38
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 89cb3d12-335a-4ac5-8d36-edbec3c3bf01

📥 Commits

Reviewing files that changed from the base of the PR and between e7870f5 and 06b4d8c.

📒 Files selected for processing (2)
  • ci/dockerfiles/integration/Dockerfile
  • packages/director/packaging

Walkthrough

This pull request modernizes Bundler configuration syntax across two build contexts. The integration Dockerfile's Ruby installation block updates global Bundler configuration to use the bundle config set --global command form for setting the install path and bin directory. Concurrently, the director packaging script updates database gem build configuration (mysql2 and pg) to use the same bundle config set syntax with line continuation, while maintaining the existing vendored build tool paths. No functional behavior changes; the refactoring standardizes command syntax to align with current Bundler conventions.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and only provides one sentence explaining the reason for changes. It does not follow the template structure with required sections like 'What is this change about', contextual information, testing details, release notes guidance, breaking changes, or team tags. Expand the description to follow the repository template by adding sections for change explanation, context, test results, release notes, breaking changes, and team tags.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: updating bundle config commands to use subcommands, which aligns with the actual modifications made to Dockerfile and packaging script.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update-bundle-config-cmd

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates BOSH build/CI scripts to use Bundler’s bundle config subcommands (set) to stay compatible with newer Bundler releases that no longer accept the legacy bundle config <key> <value> form.

Changes:

  • Switch bundle config build.* usage in the director package build to bundle config set build.*.
  • Switch global Bundler config in the integration image build to bundle config set --global ....

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/director/packaging Updates Bundler build config commands for mysql2/pg native extension compilation to use bundle config set.
ci/dockerfiles/integration/Dockerfile Updates global Bundler config commands (path, bin) to use bundle config set --global.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aramprice aramprice merged commit 16e697f into main May 7, 2026
26 checks passed
@aramprice aramprice deleted the update-bundle-config-cmd branch May 7, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants