Repository navigation
Conversation
The update-homebrew job only wrote cf-cli@N.rb on each release, leaving the unversioned cf-cli formula stale on the tap. Add a second heredoc to generate cf-cli.rb with class CfCli using the same checksums and URLs, and stage it alongside the versioned file. Also fix a shell syntax bug: missing space before ] in the porcelain check caused the condition to always be true. Fixes cloudfoundry/homebrew-tap#94
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
The
update-homebrewjob in.github/workflows/release-update-repos.ymlnever updates the unversionedcf-cli.rbformula. That formula has been pinned to v6.53.0 since it was first created.This PR adds a second heredoc in the "Generate Homebrew formula file" step that writes
cf-cli.rbalongsidecf-cli@${VERSION_MAJOR}.rb.Why Is This PR Valuable?
This change makes every future release automatically keep
cf-cliin sync with the latest major version, so the unversioned formula always installs current software.Applicable Issues
Fixes cloudfoundry/homebrew-tap#94
How Urgent Is The Change?
Medium.
Other Relevant Parties
N/A
Notes for Reviewers
Is a second PR in the v8 branch required?