Repository navigation
fix(theme): entry links follow collection permalinks; auto-merge waits for checks - #19
Merged
Merged
Conversation
…s for checks - `EntryList` calls `entryPath(media?.permalinks, e)` and the page passes `permalinks: site` (and `site` to `loadComments`), as the starter does since Cloudhal 0.3.11. The old one-argument call works again in 0.3.13 but ignores collection permalinks. - `cloudhal-update.yml` merges with `--auto`: the merge ran before the required Workers Builds check had finished and was refused (#18). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Madraka <8898640+Madraka@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EntryListusesentryPath(media?.permalinks, e), and[...path].astropassespermalinks: sitein the media context (plussitetoloadComments), matching the starter since Cloudhal 0.3.11.entryPath(e)is what blanked the site on 0.3.12. It works again since 0.3.13 (fix(core-ts): entryPath accepts the old one-argument call again cloudhal#79) but ignores collection permalinks.cloudhal-update.yml:gh pr merge --auto. Dependabot chore: Bump the cloudhal group with 12 updates #18's merge ran before the required Workers Builds check finished and was refused by the branch policy; with--autoit waits.Checked locally with
cloudhal dev:/and/blogrender (221 kB, 205 kB), entry links are/blog/<slug>, no errors in the log.🤖 Generated with Claude Code