feat(admin): add Triggers API for webhook notification management#130
feat(admin): add Triggers API for webhook notification management#130NitriKx wants to merge 1 commit into
Conversation
|
@NitriKx great PR! Would you mind adding a few specs for the newly added APIs? |
NitriKx
force-pushed
the
bsa/add-triggers-webhook-api
branch
from
1579cd8 to
abbd800
Compare
Adds typed bindings for the Cloudinary /triggers endpoint: ListTriggers, GetTrigger, CreateTrigger, UpdateTrigger, DeleteTrigger. Supports filter (JSONLogic), payload_template (Mustache), auth_scheme, and additive flag. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
NitriKx
force-pushed
the
bsa/add-triggers-webhook-api
branch
from
abbd800 to
06db2ef
Compare
|
Hello @const-cloudinary 👋 I've added few tests (inspired from what has been done for the folders) |
|
Heey 👋 Can we merge this? |
const-cloudinary
left a comment
const-cloudinary
left a comment
There was a problem hiding this comment.
@NitriKx Great PR overall!
Please drop GetTrigger (see comment) and we are good to merge and release it.
| // GetTrigger retrieves a single webhook notification trigger by its ID. | ||
| // Cloudinary does not expose a single-resource GET endpoint, so this is | ||
| // implemented as ListTriggers filtered to the matching ID. | ||
| func (a *API) GetTrigger(ctx context.Context, params GetTriggerParams) (*GetTriggerResult, error) { |
There was a problem hiding this comment.
Let's drop this one. The API itself doesn't support it.
Current implementation is trivial, anyone can implement it in their code.
The real reason for dropping it, is if/when it will be implemented in the API side, it might have different structure and it will introduce a breaking change, which we would like to avoid.
There was a problem hiding this comment.
Thanks for you comment it's fixed
2 participants
Adds full CRUD operations for the Cloudinary webhook notification triggers endpoint (
/v1_1/{cloud}/triggers)Tested against the live Cloudinary API via a Terraform provider integration (create + update + delete round-trip).