fix(ui): show full playback rate values in the rates menu - #1074
Merged
Conversation
video.js caps the playback rate menu at a fixed 4em. Once the menu item padding and the selected-item checkmark gutter are subtracted, rates like 1.75x no longer fit and get ellipsized to "1...". The menu content is absolutely positioned, so it - not the menu box - is the element that has to grow: size it to max-content, with min-width 100% so short rate lists keep the original popup width. Also widen the control itself to 3em, since the 1.75x label measures 36.1px against the stock 2.5em (36px) button and crowds the neighbouring control. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
video.js caps the playback rate menu at a fixed 4em. Once the menu item padding and the selected-item checkmark gutter are subtracted, rates like 1.75x no longer fit and get ellipsized to "1...".
The menu content is absolutely positioned, so it - not the menu box - is the element that has to grow: size it to max-content, with min-width 100% so short rate lists keep the original popup width. Also widen the control itself to 3em, since the 1.75x label measures 36.1px against the stock 2.5em (36px) button and crowds the neighbouring control.