Repository navigation
Clean up Fabric8 migration leftovers - #620
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The cleanup is internally consistent, preserves the intended behavior, and includes focused test updates.
Review effort: Balanced
Findings: None
What changed in this PR
Completes the Fabric8 Kubernetes Client migration by removing obsolete kubectl-oriented APIs and updating runtime operations and tests.
Changes:
- Replaces generic kubectl-style pod and label operations with typed Fabric8 APIs.
- Removes unused Kubernetes helpers and shell dependencies.
- Re-enables and strengthens monitoring, Jenkins, and image-pull-secret tests.
| File | Description |
|---|---|
.dockerignore |
Removes the deleted utility script from the allowlist. |
scripts/get-remote-url |
Inlines the remaining kubectl helper. |
scripts/jenkins/init-jenkins.sh |
Removes obsolete utility sourcing and hostname setup. |
scripts/utils.sh |
Deletes unused kubectl shell helpers. |
src/main/java/com/cloudogu/gitops/infrastructure/kubernetes/api/K8sClient.java |
Simplifies APIs and adds typed temporary-pod execution and node-label removal. |
src/main/java/com/cloudogu/gitops/infrastructure/kubernetes/api/K8sClientHelper.java |
Removes kubectl compatibility logic and streamlines temporary-pod cleanup. |
src/main/java/com/cloudogu/gitops/tools/core/Jenkins.java |
Uses Fabric8 pod construction and explicit node labeling. |
src/test/java/com/cloudogu/gitops/application/content/ContentLoaderTest.java |
Re-enables isolated image-pull-secret tests. |
src/test/java/com/cloudogu/gitops/infrastructure/kubernetes/api/K8sClientTest.java |
Updates coverage for the revised Kubernetes APIs. |
src/test/java/com/cloudogu/gitops/integration/tools/MonitoringTestIT.java |
Waits for the Prometheus pod instead of asserting a fixed pod count. |
src/test/java/com/cloudogu/gitops/tools/MonitoringTest.java |
Verifies Grafana mail-secret creation. |
src/test/java/com/cloudogu/gitops/tools/core/JenkinsTest.java |
Verifies the typed temporary pod and node-label operations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete the remaining cleanup after migrating Kubernetes operations from
kubectlto the Fabric8 Kubernetes Client.The changes remove leftover kubectl-specific semantics, dead Kubernetes client APIs and incomplete tests while keeping the existing GOP behavior.
Changes
run()API and CLI flags with an explicit temporary pod operationPodBuilderK8sClientconvenience overloadsVerification
Remaining
kubectlusages are limited to documentation, local/development tooling and user-facing helper commands and are not runtime dependencies of the GOP.