Skip to content

chore: Change all remaining internal uses of aria-live to LiveRegion component#4470

Open
avinashbot wants to merge 2 commits into
mainfrom
live-region-internal
Open

chore: Change all remaining internal uses of aria-live to LiveRegion component#4470
avinashbot wants to merge 2 commits into
mainfrom
live-region-internal

Conversation

@avinashbot
Copy link
Copy Markdown
Member

@avinashbot avinashbot commented Apr 27, 2026

Description

Also added a new internal LiveRegion API, preventInitialAnnouncement. May externalize it if it proves helpful, but for now, it's internal-only and opt-in.

Related links, issue #, if available: AWSUI-22299

How has this been tested?

Kept existing tests, which should continue working. Manually tested the two cases on VoiceOver.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@avinashbot avinashbot force-pushed the live-region-internal branch from 9a02363 to 94d57b7 Compare April 27, 2026 07:59
) : null}
</InternalSpaceBetween>

<div aria-live="polite">
Copy link
Copy Markdown
Member Author

@avinashbot avinashbot Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a bit of manual testing, I'm honestly not sure why this was wrapped with an aria-live — there's nothing dynamically changing in the tutorial list. I believe the purpose this was supposed to serve was essentially replaced by the newly added focus-on-complete behavior in #4167.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.40%. Comparing base (a4aa195) to head (039a1d6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4470   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files         933      933           
  Lines       29486    29493    +7     
  Branches    10697    10699    +2     
=======================================
+ Hits        28720    28727    +7     
  Misses        759      759           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avinashbot avinashbot marked this pull request as ready for review April 28, 2026 09:37
@avinashbot avinashbot requested a review from a team as a code owner April 28, 2026 09:37
@avinashbot avinashbot requested review from NathanZlion and removed request for a team April 28, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants