Skip to content

fix: Listen to owner window on scroll, add more tests.#4481

Draft
NathanZlion wants to merge 2 commits into
mainfrom
dev-v3-natidere-iframe
Draft

fix: Listen to owner window on scroll, add more tests.#4481
NathanZlion wants to merge 2 commits into
mainfrom
dev-v3-natidere-iframe

Conversation

@NathanZlion
Copy link
Copy Markdown
Member

@NathanZlion NathanZlion commented Apr 30, 2026

Description

Updated internal.tsx, internal/components/tooltip, and click-away.tsx to use getOwnerWindow/ownerDocument instead of global window/document for scroll, click, resize, and keydown listeners.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@NathanZlion NathanZlion requested a review from a team as a code owner April 30, 2026 11:09
@NathanZlion NathanZlion requested review from taheramr and removed request for a team April 30, 2026 11:09
@NathanZlion NathanZlion marked this pull request as draft April 30, 2026 11:10
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.40%. Comparing base (151ff09) to head (cd23c94).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4481   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files         933      933           
  Lines       29554    29562    +8     
  Branches    10736    10738    +2     
=======================================
+ Hits        28788    28796    +8     
  Misses        759      759           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant