Skip to content

fix: Remove underline from trailing whitespace in external links#4497

Draft
avinashbot wants to merge 3 commits into
mainfrom
fix-link-underline
Draft

fix: Remove underline from trailing whitespace in external links#4497
avinashbot wants to merge 3 commits into
mainfrom
fix-link-underline

Conversation

@avinashbot
Copy link
Copy Markdown
Member

@avinashbot avinashbot commented May 7, 2026

Description

Resurrecting a contribution in #3709 that neither I nor the contributor could find a path forward for. While spending time investigating a fix for #4496, I discovered a trick that lets us do this without a space (apparently this character existed for many years now, just hadn't come across it until just now).

Keeping the original commit in there to maintain the attribution to the original contributor who kicked it off.

Related links, issue #, if available: AWSUI-60840

How has this been tested?

Would definitely show up in screenshot tests.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

xyos and others added 3 commits May 7, 2026 16:19
Removes the non-breaking space that caused underlines to appear below
trailing whitespace between external icon and link text. Replaces it
with margin-inline-start.

AWSUI-60840
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.41%. Comparing base (16e2159) to head (e70fa80).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4497   +/-   ##
=======================================
  Coverage   97.41%   97.41%           
=======================================
  Files         933      933           
  Lines       29595    29595           
  Branches    10757    10756    -1     
=======================================
  Hits        28831    28831           
- Misses        716      757   +41     
+ Partials       48        7   -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants