Skip to content

chore: Adds disable dismiss auto-focis for internal chart tooltip#4510

Merged
pan-kot merged 1 commit into
mainfrom
chore-disable-internal-tooltip-dismiss-autofocus
May 12, 2026
Merged

chore: Adds disable dismiss auto-focis for internal chart tooltip#4510
pan-kot merged 1 commit into
mainfrom
chore-disable-internal-tooltip-dismiss-autofocus

Conversation

@pan-kot
Copy link
Copy Markdown
Member

@pan-kot pan-kot commented May 12, 2026

Description

This change is required to support cloudscape-design/chart-components#217, where the use case requires the dismiss button to appear, while the focus stays on the legend item - this is different from the conventional popover use with click activation or charts use, where the tooltip does not have a dismiss button unless pinned.

How has this been tested?

  • New unit test
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.41%. Comparing base (f493264) to head (3665672).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4510   +/-   ##
=======================================
  Coverage   97.41%   97.41%           
=======================================
  Files         933      933           
  Lines       29595    29596    +1     
  Branches    10757    10758    +1     
=======================================
+ Hits        28831    28832    +1     
  Misses        716      716           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pan-kot pan-kot added this pull request to the merge queue May 12, 2026
Merged via the queue into main with commit bb73d4f May 12, 2026
50 checks passed
@pan-kot pan-kot deleted the chore-disable-internal-tooltip-dismiss-autofocus branch May 12, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants