Skip to content

lsp: validate range bounds in Locate to avoid panic on malformed LSP ranges #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

lsp: validate range bounds in Locate to avoid panic on malformed LSP ranges #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lang/lsp/lsp_methods.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,9 +310,18 @@ func (cli *LSPClient) Locate(id Location) (string, error) {
}

text := f.Text
// get block text of range
// LSP servers (e.g. jedi/parso on partially-supported syntax) occasionally return
// malformed ranges where Start > End or the offsets fall outside the document.
// Return an error rather than panicking.
if id.Range.Start.Line < 0 || id.Range.End.Line < 0 ||
id.Range.Start.Line >= len(f.LineCounts) || id.Range.End.Line >= len(f.LineCounts) {
return "", fmt.Errorf("locate: line out of range %v in %s", id.Range, id.URI)
}
start := f.LineCounts[id.Range.Start.Line] + id.Range.Start.Character
end := f.LineCounts[id.Range.End.Line] + id.Range.End.Character
if start < 0 || end < 0 || start > end || end > len(text) {
return "", fmt.Errorf("locate: invalid range [%d:%d] (text len %d) in %s", start, end, len(text), id.URI)
}
return text[start:end], nil
}

Expand Down