fix(simd): support SSE2 on 32-bit x86 - #236
Open
felix-windsor wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core::arch::x86on 32-bit x86 and retaincore::arch::x86_64on 64-bit x86Motivation
On an i386/i686 target with SSE2 enabled,
sonic-simdselectssse2.rs, but that module unconditionally importscore::arch::x86_64. The resulting build fails because the x86_64 architecture module does not exist on 32-bit x86.Validation
Before this change, the following command reproduced the error from #231:
After the change:
RUSTFLAGS="-C target-feature=+sse2" cargo check -p sonic-simd --target i686-unknown-linux-gnucargo test -p sonic-simdcargo fmt -- --checkFixes #231